Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e88a301

Browse filesBrowse files
targostargos
committed
tools: do not pass invalid flag to C compiler
`-Wno-invalid-offsetof` is only valid for C++ and GCC warns about its usage for C. PR-URL: #51409 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent ec60639 commit e88a301
Copy full SHA for e88a301

File tree

Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1989,6 +1989,12 @@
19891989
]
19901990
}],
19911991
],
1992+
# -Wno-invalid-offsetof flag is not valid for C.
1993+
# The flag is initially set in `toolchain.gypi` for all targets.
1994+
'cflags!': [ '-Wno-invalid-offsetof' ],
1995+
'xcode_settings': {
1996+
'WARNING_CFLAGS!': ['-Wno-invalid-offsetof']
1997+
},
19921998
'direct_dependent_settings': {
19931999
'include_dirs': [
19942000
'<(V8_ROOT)/third_party/zlib',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.