Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e8538c3

Browse filesBrowse files
MrJithiltargos
authored andcommitted
build: fix node build failures in WSL Ubuntu
On WSL systems, `./configure` causes appending of carriage return (`\r\r`) as leftover and will be appended to the `gyp_args`. Therefore, it will lead to unhandled exceptions from the `./configure` execution. Excluded the empty or whitespace item from the `args` array to fix the issue. Fixes: #41459 PR-URL: #41476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent f5b8aee commit e8538c3
Copy full SHA for e8538c3

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2030,8 +2030,8 @@ def make_bin_override():
20302030
if bin_override is not None:
20312031
gyp_args += ['-Dpython=' + sys.executable]
20322032

2033-
# pass the leftover positional arguments to GYP
2034-
gyp_args += args
2033+
# pass the leftover non-whitespace positional arguments to GYP
2034+
gyp_args += [arg for arg in args if not str.isspace(arg)]
20352035

20362036
if warn.warned and not options.verbose:
20372037
warn('warnings were emitted in the configure phase')

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.