Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e7c4dfb

Browse filesBrowse files
Sam ShullMylesBorins
Sam Shull
authored and
MylesBorins
committed
test: invalid package.json causes error when require()ing in directory
Requiring a file from a directory that contains an invalid package.json file should throw an error. PR-URL: #10044 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 22226fa commit e7c4dfb
Copy full SHA for e7c4dfb

File tree

Expand file treeCollapse file tree

3 files changed

+9
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+9
-0
lines changed
Open diff view settings
Collapse file

‎test/fixtures/packages/invalid/index.js‎

Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
exports.ok = 'ok';
Collapse file

‎test/fixtures/packages/invalid/package.json‎

Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{,}
Collapse file

‎test/sequential/test-module-loading.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-module-loading.js
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,13 @@ assert.strictEqual(threeFolder, threeIndex);
6969
assert.notStrictEqual(threeFolder, three);
7070

7171
console.error('test package.json require() loading');
72+
assert.throws(
73+
function() {
74+
require('../fixtures/packages/invalid');
75+
},
76+
/^SyntaxError: Error parsing \S+: Unexpected token ,$/
77+
);
78+
7279
assert.strictEqual(require('../fixtures/packages/main').ok, 'ok',
7380
'Failed loading package');
7481
assert.strictEqual(require('../fixtures/packages/main-index').ok, 'ok',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.