Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e7b656d

Browse filesBrowse files
addaleaxItalo A. Casas
authored andcommitted
Revert "repl: disable Ctrl+C support on win32 for now"
This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 6e8d627 commit e7b656d
Copy full SHA for e7b656d

File tree

Expand file treeCollapse file tree

1 file changed

+2
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-9
lines changed
Open diff view settings
Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js
+2-9Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,7 @@ function REPLServer(prompt,
322322
if (!err) {
323323
// Unset raw mode during evaluation so that Ctrl+C raises a signal.
324324
let previouslyInRawMode;
325-
326-
// Temporarily disabled on Windows due to output problems that likely
327-
// result from the raw mode switches here, see
328-
// https://github.com/nodejs/node/issues/7837
329-
// Setting NODE_REPL_CTRLC is meant as a temporary opt-in for debugging.
330-
if (self.breakEvalOnSigint &&
331-
(process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
325+
if (self.breakEvalOnSigint) {
332326
// Start the SIGINT watchdog before entering raw mode so that a very
333327
// quick Ctrl+C doesn’t lead to aborting the process completely.
334328
utilBinding.startSigintWatchdog();
@@ -348,8 +342,7 @@ function REPLServer(prompt,
348342
result = script.runInContext(context, scriptOptions);
349343
}
350344
} finally {
351-
if (self.breakEvalOnSigint &&
352-
(process.platform !== 'win32' || process.env.NODE_REPL_CTRLC)) {
345+
if (self.breakEvalOnSigint) {
353346
// Reset terminal mode to its previous value.
354347
self._setRawMode(previouslyInRawMode);
355348

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.