Commit e60d905
stream: fix duplexify premature destroy
The duplexified Duplex should be autoDestroyed instead of
prematurely destroyed when the readable and writable sides
have finished without error.
Fixes: #44925
PR-URL: #45133
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent 58bec56 commit e60d905Copy full SHA for e60d905
File tree
Expand file treeCollapse file tree
2 files changed
+22
-3
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
2 files changed
+22
-3
lines changedOpen diff view settings
Collapse file
lib/internal/streams/duplexify.js
Copy file name to clipboardExpand all lines: lib/internal/streams/duplexify.js-2Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
262 | 262 | |
263 | 263 | |
264 | 264 | |
265 | | - |
266 | | - |
267 | 265 | |
268 | 266 | |
269 | 267 | |
|
Collapse file
test/parallel/test-stream-duplex-from.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-duplex-from.js+22-1Lines changed: 22 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2 | 2 | |
3 | 3 | |
4 | 4 | |
5 | | - |
| 5 | + |
6 | 6 | |
7 | 7 | |
8 | 8 | |
| ||
278 | 278 | |
279 | 279 | |
280 | 280 | |
| 281 | + |
| 282 | + |
| 283 | + |
| 284 | + |
| 285 | + |
| 286 | + |
| 287 | + |
| 288 | + |
| 289 | + |
| 290 | + |
| 291 | + |
| 292 | + |
| 293 | + |
| 294 | + |
| 295 | + |
| 296 | + |
| 297 | + |
| 298 | + |
| 299 | + |
| 300 | + |
| 301 | + |
0 commit comments