Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e5dae20

Browse filesBrowse files
Trottrvagg
authored andcommitted
doc: remove deprecation definition in Collaborator Guide
The Collaborator Guide links to a definition of "deprecation" but also quotes it extensively. Remove the extensive quotes. PR-URL: #26157 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 59ca9e9 commit e5dae20
Copy full SHA for e5dae20

File tree

Expand file treeCollapse file tree

1 file changed

+2
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-8
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+2-8Lines changed: 2 additions & 8 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,7 @@ guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api
319319

320320
### Deprecations
321321

322-
[_Deprecation_][] is "the discouragement of use of some … feature … or practice,
323-
typically because it has been superseded or is no longer considered efficient or
324-
safe, without completely removing it or prohibiting its use. It can also imply
325-
that a feature, design, or practice will be removed or discontinued entirely in
326-
the future."
327-
328-
Node.js uses three Deprecation levels:
322+
Node.js uses three [Deprecation][] levels:
329323

330324
* *Documentation-Only Deprecation*: A deprecation notice is added to the API
331325
documentation but no functional changes are implemented in the code. By
@@ -795,9 +789,9 @@ When things need extra attention, are controversial, or `semver-major`:
795789
If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
796790

797791
["Merge Pull Request"]: https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-on-github
792+
[Deprecation]: https://en.wikipedia.org/wiki/Deprecation
798793
[Stability Index]: doc/api/documentation.md#stability-index
799794
[TSC]: https://github.com/nodejs/TSC
800-
[_Deprecation_]: https://en.wikipedia.org/wiki/Deprecation
801795
[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
802796
[`--throw-deprecation`]: doc/api/cli.md#--throw-deprecation
803797
[`node-core-utils`]: https://github.com/nodejs/node-core-utils

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.