Commit e5d2a95
src: remove out-of-date TODO comment
This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.
While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:
$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc
$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'
git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'
Removing the TODO comment seems appropriate in this case.
PR-URL: #9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent b4353e9 commit e5d2a95Copy full SHA for e5d2a95
File tree
Expand file treeCollapse file tree
1 file changed
+0
-1
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+0
-1
lines changedOpen diff view settings
Collapse file
-1Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
342 | 342 | |
343 | 343 | |
344 | 344 | |
345 | | - |
346 | 345 | |
347 | 346 | |
348 | 347 | |
|
0 commit comments