Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e5b7d64

Browse filesBrowse files
Sebastien-Ahkrintargos
Sebastien-Ahkrin
authored and
targos
committed
lib: replace Set global by the primordials
PR-URL: #31154 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 869cd53 commit e5b7d64
Copy full SHA for e5b7d64

File tree

Expand file treeCollapse file tree

13 files changed

+17
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

13 files changed

+17
-0
lines changed
Open diff view settings
Collapse file

‎lib/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: lib/.eslintrc.yaml
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ rules:
2727
message: "Use `const { Promise } = primordials;` instead of the global."
2828
- name: Reflect
2929
message: "Use `const { Reflect } = primordials;` instead of the global."
30+
- name: Set
31+
message: "Use `const { Set } = primordials;` instead of the global."
3032
- name: Symbol
3133
message: "Use `const { Symbol } = primordials;` instead of the global."
3234
- name: WeakMap
Collapse file

‎lib/internal/fs/rimraf.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/rimraf.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
const {
1010
Promise,
11+
Set,
1112
} = primordials;
1213

1314
const {
Collapse file

‎lib/internal/http2/core.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/core.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const {
1212
ObjectPrototypeHasOwnProperty,
1313
Promise,
1414
ReflectGetPrototypeOf,
15+
Set,
1516
Symbol,
1617
} = primordials;
1718

Collapse file

‎lib/internal/http2/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/util.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const {
66
Number,
77
ObjectCreate,
88
ObjectKeys,
9+
Set,
910
Symbol,
1011
} = primordials;
1112

Collapse file

‎lib/internal/inspector_async_hook.js‎

Copy file name to clipboardExpand all lines: lib/internal/inspector_async_hook.js
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
let hook;
44
let config;
55

6+
const {
7+
Set,
8+
} = primordials;
9+
610
function lazyHookCreation() {
711
const inspector = internalBinding('inspector');
812
const { createHook } = require('async_hooks');
Collapse file

‎lib/internal/modules/esm/create_dynamic_module.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/create_dynamic_module.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ const {
55
ArrayPrototypeMap,
66
JSONStringify,
77
ObjectCreate,
8+
Set,
89
} = primordials;
910

1011
const debug = require('internal/util/debuglog').debuglog('esm');
Collapse file

‎lib/internal/process/per_thread.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/per_thread.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const {
1212
ObjectFreeze,
1313
ObjectGetOwnPropertyDescriptors,
1414
RegExpPrototypeTest,
15+
Set,
1516
SetPrototype,
1617
SetPrototypeHas,
1718
StringPrototypeReplace,
Collapse file

‎lib/internal/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/util.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const {
1212
ObjectSetPrototypeOf,
1313
Promise,
1414
ReflectConstruct,
15+
Set,
1516
Symbol,
1617
SymbolFor,
1718
} = primordials;
Collapse file

‎lib/internal/util/comparisons.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const {
1414
ObjectPrototypeHasOwnProperty,
1515
ObjectPrototypePropertyIsEnumerable,
1616
ObjectPrototypeToString,
17+
Set,
1718
StringPrototypeValueOf,
1819
SymbolPrototypeValueOf,
1920
} = primordials;
Collapse file

‎lib/internal/util/inspect.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ const {
3434
ObjectPrototypePropertyIsEnumerable,
3535
ObjectSeal,
3636
RegExpPrototypeToString,
37+
Set,
3738
SetPrototypeValues,
3839
StringPrototypeValueOf,
3940
SymbolPrototypeToString,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.