Commit e580a44
test: don't inspect values if not necessary
The inspection triggered on each assert call eagerly even tough the
assertion was never triggered. That caused significant CPU overhead.
PR-URL: #22903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 624e516 commit e580a44Copy full SHA for e580a44
File tree
Expand file treeCollapse file tree
4 files changed
+39
-12
lines changedOpen diff view settings
Filter options
- test
- common
- internet
- parallel
Expand file treeCollapse file tree
4 files changed
+39
-12
lines changedOpen diff view settings
Collapse file
+19-6Lines changed: 19 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
33 | 33 | |
34 | 34 | |
35 | 35 | |
36 | | - |
| 36 | + |
37 | 37 | |
38 | | - |
39 | | - |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
40 | 47 | |
41 | 48 | |
42 | 49 | |
| ||
57 | 64 | |
58 | 65 | |
59 | 66 | |
60 | | - |
61 | | - |
62 | | - |
| 67 | + |
| 68 | + |
| 69 | + |
| 70 | + |
| 71 | + |
| 72 | + |
| 73 | + |
| 74 | + |
| 75 | + |
63 | 76 | |
64 | 77 | |
65 | 78 | |
|
Collapse file
test/internet/test-trace-events-dns.js
Copy file name to clipboardExpand all lines: test/internet/test-trace-events-dns.js+6-1Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
49 | 49 | |
50 | 50 | |
51 | 51 | |
52 | | - |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
53 | 58 | |
54 | 59 | |
55 | 60 | |
|
Collapse file
test/parallel/test-trace-events-fs-sync.js
Copy file name to clipboardExpand all lines: test/parallel/test-trace-events-fs-sync.js+6-1Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
136 | 136 | |
137 | 137 | |
138 | 138 | |
139 | | - |
| 139 | + |
| 140 | + |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
140 | 145 | |
141 | 146 | |
142 | 147 | |
|
Collapse file
test/parallel/test-worker-message-port-transfer-self.js
Copy file name to clipboardExpand all lines: test/parallel/test-worker-message-port-transfer-self.js+8-4Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
27 | 27 | |
28 | 28 | |
29 | 29 | |
30 | | - |
31 | | - |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
32 | 34 | |
33 | 35 | |
34 | 36 | |
35 | 37 | |
36 | | - |
37 | | - |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
38 | 42 | |
39 | 43 | |
40 | 44 | |
|
0 commit comments