Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e553747

Browse filesBrowse files
TrottMylesBorins
Trott
authored and
MylesBorins
committed
doc: update Collaborator Guide reference
In pull-requests.md: * Refer to the Collaborator Guide as Collaborator Guide and not Collaborator's Guide. That is how the doc describes itself and we should be consistent. PR-URL: #20473 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent b6de6a7 commit e553747
Copy full SHA for e553747

File tree

Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+5-5Lines changed: 5 additions & 5 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ so that you can make the actual changes. This is where we will start.
3535
* [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request)
3636
* [CI Testing](#ci-testing)
3737
* [Waiting Until the Pull Request Gets Landed](#waiting-until-the-pull-request-gets-landed)
38-
* [Check Out the Collaborator's Guide](#check-out-the-collaborators-guide)
38+
* [Check Out the Collaborator Guide](#check-out-the-collaborator-guide)
3939

4040
## Dependencies
4141

@@ -645,17 +645,17 @@ doesn't need to wait. A Pull Request may well take longer to be
645645
merged in. All these precautions are important because Node.js is
646646
widely used, so don't be discouraged!
647647

648-
### Check Out the Collaborator's Guide
648+
### Check Out the Collaborator Guide
649649

650-
If you want to know more about the code review and the landing process,
651-
you can take a look at the
652-
[collaborator's guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md).
650+
If you want to know more about the code review and the landing process, see the
651+
[Collaborator Guide][].
653652

654653
[approved]: #getting-approvals-for-your-pull-request
655654
[benchmark results]: ../writing-and-running-benchmarks.md
656655
[Building guide]: ../../../BUILDING.md
657656
[CI (Continuous Integration) test run]: #ci-testing
658657
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
658+
[Collaborator Guide]: ../../../COLLABORATOR_GUIDE.md
659659
[guide for writing tests in Node.js]: ../writing-tests.md
660660
[https://ci.nodejs.org/]: https://ci.nodejs.org/
661661
[IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.