Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e4f802d

Browse filesBrowse files
Trottdanielleadams
authored andcommitted
debugger: rename internal library for clarity
When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: #39080 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 7b026d8 commit e4f802d
Copy full SHA for e4f802d

File tree

Expand file treeCollapse file tree

5 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

5 files changed

+6
-6
lines changed
Open diff view settings
Collapse file
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ const console = require('internal/console/global');
3939

4040
const { 0: InspectClient, 1: createRepl } =
4141
[
42-
require('internal/inspector/inspect_client'),
43-
require('internal/inspector/inspect_repl'),
42+
require('internal/debugger/inspect_client'),
43+
require('internal/debugger/inspect_repl'),
4444
];
4545

4646
const debuglog = util.debuglog('inspect');
Collapse file

‎lib/internal/main/inspect.js‎

Copy file name to clipboardExpand all lines: lib/internal/main/inspect.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ markBootstrapComplete();
1313

1414
// Start the debugger agent.
1515
process.nextTick(() => {
16-
require('internal/inspector/_inspect').start();
16+
require('internal/debugger/_inspect').start();
1717
});
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,9 @@
143143
'lib/internal/crypto/webcrypto.js',
144144
'lib/internal/crypto/x509.js',
145145
'lib/internal/constants.js',
146+
'lib/internal/debugger/_inspect.js',
147+
'lib/internal/debugger/inspect_client.js',
148+
'lib/internal/debugger/inspect_repl.js',
146149
'lib/internal/dgram.js',
147150
'lib/internal/dns/promises.js',
148151
'lib/internal/dns/utils.js',
@@ -166,9 +169,6 @@
166169
'lib/internal/heap_utils.js',
167170
'lib/internal/histogram.js',
168171
'lib/internal/idna.js',
169-
'lib/internal/inspector/_inspect.js',
170-
'lib/internal/inspector/inspect_client.js',
171-
'lib/internal/inspector/inspect_repl.js',
172172
'lib/internal/inspector_async_hook.js',
173173
'lib/internal/js_stream_socket.js',
174174
'lib/internal/legacy/processbinding.js',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.