Commit e48ec70
domain: improve deprecation warning text for DEP0097
Because the following gives basically no actionable information
on its own, neither in the error message nor in the stack trace:
(node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
at emitMakeCallbackDeprecation (domain.js:123:13)
at process.topLevelDomainCallback (domain.js:135:5)
at process.callbackTrampoline (internal/async_hooks.js:124:14)
PR-URL: #36136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent d8fcf2c commit e48ec70Copy full SHA for e48ec70
Expand file treeCollapse file tree
2 files changed
+17
-6
lines changedOpen diff view settings
Collapse file
+6-3Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
124 | 124 | |
125 | 125 | |
126 | 126 | |
127 | | - |
| 127 | + |
128 | 128 | |
129 | 129 | |
130 | 130 | |
131 | 131 | |
132 | | - |
| 132 | + |
| 133 | + |
| 134 | + |
| 135 | + |
133 | 136 | |
134 | 137 | |
135 | 138 | |
136 | 139 | |
137 | 140 | |
138 | 141 | |
139 | 142 | |
140 | | - |
| 143 | + |
141 | 144 | |
142 | 145 | |
143 | 146 | |
|
Collapse file
test/addons/make-callback-domain-warning/test.js
Copy file name to clipboardExpand all lines: test/addons/make-callback-domain-warning/test.js+11-3Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
9 | | - |
| 9 | + |
10 | 10 | |
11 | 11 | |
12 | 12 | |
| ||
16 | 16 | |
17 | 17 | |
18 | 18 | |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
19 | 25 | |
20 | | - |
| 26 | + |
21 | 27 | |
22 | 28 | |
23 | 29 | |
| ||
26 | 32 | |
27 | 33 | |
28 | 34 | |
29 | | - |
| 35 | + |
| 36 | + |
| 37 | + |
30 | 38 | |
31 | 39 | |
32 | 40 | |
|
0 commit comments