Commit e47fd4c
src: add nullptr check for session in DEBUG macro
Currenlty when configuring --debug-http2
/test/parallel/test-http2-getpackedsettings.js will segment fault:
$ out/Debug/node test/parallel/test-http2-getpackedsettings.js
Segmentation fault: 11
This is happening because the settings is created with the Environment in
PackSettings:
Http2Session::Http2Settings settings(env);
This will cause the session to be set to nullptr. When the init
function is later called the expanded DEBUG_HTTP2SESSION macro will
cause the segment fault when the session is dereferenced.
PR-URL: #18815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 4601bfd commit e47fd4cCopy full SHA for e47fd4c
File tree
Expand file treeCollapse file tree
1 file changed
+10
-6
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+10
-6
lines changedOpen diff view settings
Collapse file
+10-6Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
39 | 39 | |
40 | 40 | |
41 | 41 | |
42 | | - |
43 | | - |
44 | | - |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
45 | 47 | |
46 | 48 | |
47 | 49 | |
48 | | - |
49 | | - |
50 | | - |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
51 | 54 | |
| 55 | + |
52 | 56 | |
53 | 57 | |
54 | 58 | |
|
0 commit comments