Commit e474c67
readline: establish y in cursorTo as optional
Parameter y in cursorTo() is optional and this is also verified by
tests but docs don't state this. Besides that if the newly added
parameter callback is used with no y, it's quite unhandy. This PR allows
to simply omit y.
PR-URL: #29128
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent e51f924 commit e474c67Copy full SHA for e474c67
File tree
Expand file treeCollapse file tree
4 files changed
+15
-2
lines changedOpen diff view settings
Filter options
- doc/api
- lib
- test/parallel
Expand file treeCollapse file tree
4 files changed
+15
-2
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
487 | 487 | |
488 | 488 | |
489 | 489 | |
490 | | - |
| 490 | + |
491 | 491 | |
492 | 492 | |
493 | 493 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
145 | 145 | |
146 | 146 | |
147 | 147 | |
148 | | - |
| 148 | + |
149 | 149 | |
150 | 150 | |
151 | 151 | |
|
Collapse file
+5Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1193 | 1193 | |
1194 | 1194 | |
1195 | 1195 | |
| 1196 | + |
| 1197 | + |
| 1198 | + |
| 1199 | + |
| 1200 | + |
1196 | 1201 | |
1197 | 1202 | |
1198 | 1203 | |
|
Collapse file
test/parallel/test-readline-csi.js
Copy file name to clipboardExpand all lines: test/parallel/test-readline-csi.js+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
133 | 133 | |
134 | 134 | |
135 | 135 | |
| 136 | + |
| 137 | + |
| 138 | + |
| 139 | + |
136 | 140 | |
137 | 141 | |
138 | 142 | |
| ||
141 | 145 | |
142 | 146 | |
143 | 147 | |
| 148 | + |
| 149 | + |
| 150 | + |
| 151 | + |
144 | 152 | |
145 | 153 | |
146 | 154 | |
|
0 commit comments