Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e457ec0

Browse filesBrowse files
Ayase-252targos
authored andcommitted
lib: fix checking syntax of esm module
Fixes: #41189 PR-URL: #41198 Refs: #37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent d83a029 commit e457ec0
Copy full SHA for e457ec0

File tree

Expand file treeCollapse file tree

3 files changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/main/check_syntax.js‎

Copy file name to clipboardExpand all lines: lib/internal/main/check_syntax.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function checkSyntax(source, filename) {
5454
const { defaultResolve } = require('internal/modules/esm/resolve');
5555
const { defaultGetFormat } = require('internal/modules/esm/get_format');
5656
const { url } = defaultResolve(pathToFileURL(filename).toString());
57-
const { format } = defaultGetFormat(url);
57+
const format = defaultGetFormat(url);
5858
isModule = format === 'module';
5959
}
6060
if (isModule) {
Collapse file
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export function testFunction(req, res) {
2+
return 'PASS';
3+
}
Collapse file

‎test/sequential/test-cli-syntax-good.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-cli-syntax-good.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const syntaxArgs = [
1717
[
1818
'syntax/good_syntax.js',
1919
'syntax/good_syntax',
20+
'syntax/good_syntax.mjs',
2021
'syntax/good_syntax_shebang.js',
2122
'syntax/good_syntax_shebang',
2223
'syntax/illegal_if_not_wrapped.js',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.