Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e410514

Browse filesBrowse files
Trottruyadorno
authored andcommitted
doc: improve table accessibility
The compatibility matrix in the N-API doc needs row headers for accessibility purposes. Unfortunately, those aren't possible in markdown without resorting to HTML markup. So this converts the table from markdown to HTML. This is less convenient for documentation authors and for other readers of the raw markdown docs, but I believe accessibility for the viewers of our HTML docs outweighs that concern. PR-URL: #35146 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zeyu Yang <himself65@outlook.com>
1 parent 7dbcd24 commit e410514
Copy full SHA for e410514

File tree

Expand file treeCollapse file tree

1 file changed

+86
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+86
-10
lines changed
Open diff view settings
Collapse file

‎doc/api/n-api.md‎

Copy file name to clipboardExpand all lines: doc/api/n-api.md
+86-10Lines changed: 86 additions & 10 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -244,16 +244,92 @@ from version 3 with some additions. This means that it is not necessary
244244
to recompile for new versions of Node.js which are
245245
listed as supporting a later version.
246246

247-
| | 1 | 2 | 3 | 4 | 5 | 6 |
248-
|-------|----------|----------|----------|----------|-----------|-----------|
249-
| v6.x | | | v6.14.2* | | | |
250-
| v8.x | v8.6.0** | v8.10.0* | v8.11.2 | v8.16.0 | | |
251-
| v9.x | v9.0.0* | v9.3.0* | v9.11.0* | | | |
252-
| v10.x | v10.0.0 | v10.0.0 | v10.0.0 | v10.16.0 | v10.17.0 | v10.20.0 |
253-
| v11.x | v11.0.0 | v11.0.0 | v11.0.0 | v11.8.0 | | |
254-
| v12.x | v12.0.0 | v12.0.0 | v12.0.0 | v12.0.0 | v12.11.0 | v12.17.0 |
255-
| v13.x | v13.0.0 | v13.0.0 | v13.0.0 | v13.0.0 | v13.0.0 | |
256-
| v14.x | v14.0.0 | v14.0.0 | v14.0.0 | v14.0.0 | v14.0.0 | v14.0.0 |
247+
<!-- For accessibility purposes, this table needs row headers. That means we
248+
can't do it in markdown. Hence, the raw HTML. -->
249+
250+
<table>
251+
<tr>
252+
<td></td>
253+
<th scope="col">1</th>
254+
<th scope="col">2</th>
255+
<th scope="col">3</th>
256+
<th scope="col">4</th>
257+
<th scope="col">5</th>
258+
<th scope="col">6</th>
259+
</tr>
260+
<tr>
261+
<th scope="row">v6.x</th>
262+
<td></td>
263+
<td></td>
264+
<td>v6.14.2*</td>
265+
<td></td>
266+
<td></td>
267+
<td></td>
268+
</tr>
269+
<tr>
270+
<th scope="row">v8.x</th>
271+
<td>v8.6.0**</td>
272+
<td>v8.10.0*</td>
273+
<td>v8.11.2</td>
274+
<td>v8.16.0</td>
275+
<td></td>
276+
<td></td>
277+
</tr>
278+
<tr>
279+
<th scope="row">v9.x</th>
280+
<td>v9.0.0*</td>
281+
<td>v9.3.0*</td>
282+
<td>v9.11.0*</td>
283+
<td></td>
284+
<td></td>
285+
<td></td>
286+
</tr>
287+
<tr>
288+
<th scope="row">v10.x</th>
289+
<td>v10.0.0</td>
290+
<td>v10.0.0</td>
291+
<td>v10.0.0</td>
292+
<td>v10.16.0</td>
293+
<td>v10.17.0</td>
294+
<td>v10.20.0</td>
295+
</tr>
296+
<tr>
297+
<th scope="row">v11.x</th>
298+
<td>v11.0.0</td>
299+
<td>v11.0.0</td>
300+
<td>v11.0.0</td>
301+
<td>v11.8.0</td>
302+
<td></td>
303+
<td></td>
304+
</tr>
305+
<tr>
306+
<th scope="row">v12.x</th>
307+
<td>v12.0.0</td>
308+
<td>v12.0.0</td>
309+
<td>v12.0.0</td>
310+
<td>v12.0.0</td>
311+
<td>v12.11.0</td>
312+
<td>v12.17.0</td>
313+
</tr>
314+
<tr>
315+
<th scope="row">v13.x</th>
316+
<td>v13.0.0</td>
317+
<td>v13.0.0</td>
318+
<td>v13.0.0</td>
319+
<td>v13.0.0</td>
320+
<td>v13.0.0</td>
321+
<td></td>
322+
</tr>
323+
<tr>
324+
<th scope="row">v14.x</th>
325+
<td>v14.0.0</td>
326+
<td>v14.0.0</td>
327+
<td>v14.0.0</td>
328+
<td>v14.0.0</td>
329+
<td>v14.0.0</td>
330+
<td>v14.0.0</td>
331+
</tr>
332+
</table>
257333

258334
\* N-API was experimental.
259335

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.