Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e3bddee

Browse filesBrowse files
apapirovskiMylesBorins
authored andcommitted
http: fix undefined error in parser event
The current check for socket.server[kIncomingMessage] does not account for the possibility of a socket.server that doesn't have that property defined. Fix it. Backport-PR-URL: #22880 PR-URL: #20029 Fixes: #19231 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Khaidi Chu <i@2333.moe>
1 parent ce65d84 commit e3bddee
Copy full SHA for e3bddee

File tree

Expand file treeCollapse file tree

1 file changed

+6
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-4
lines changed
Open diff view settings
Collapse file

‎lib/_http_common.js‎

Copy file name to clipboardExpand all lines: lib/_http_common.js
+6-4Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ function parserOnHeaders(headers, url) {
6262
function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
6363
url, statusCode, statusMessage, upgrade,
6464
shouldKeepAlive) {
65-
var parser = this;
65+
const parser = this;
66+
const { socket } = parser;
6667

6768
if (!headers) {
6869
headers = parser._headers;
@@ -75,10 +76,11 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
7576
}
7677

7778
// Parser is also used by http client
78-
var ParserIncomingMessage = parser.socket && parser.socket.server ?
79-
parser.socket.server[kIncomingMessage] : IncomingMessage;
79+
const ParserIncomingMessage = (socket && socket.server &&
80+
socket.server[kIncomingMessage]) ||
81+
IncomingMessage;
8082

81-
parser.incoming = new ParserIncomingMessage(parser.socket);
83+
parser.incoming = new ParserIncomingMessage(socket);
8284
parser.incoming.httpVersionMajor = versionMajor;
8385
parser.incoming.httpVersionMinor = versionMinor;
8486
parser.incoming.httpVersion = `${versionMajor}.${versionMinor}`;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.