Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e38e2a6

Browse filesBrowse files
committed
test: bug repro for vm function redefinition
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 PR-URL: #5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 32e1f9d commit e38e2a6
Copy full SHA for e38e2a6

File tree

Expand file treeCollapse file tree

1 file changed

+11
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-0
lines changed
Open diff view settings
Collapse file
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
'use strict';
2+
// Refs: https://github.com/nodejs/node/issues/548
3+
require('../common');
4+
const assert = require('assert');
5+
const vm = require('vm');
6+
const context = vm.createContext();
7+
8+
vm.runInContext('function test() { return 0; }', context);
9+
vm.runInContext('function test() { return 1; }', context);
10+
const result = vm.runInContext('test()', context);
11+
assert.strictEqual(result, 1);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.