Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e2df381

Browse filesBrowse files
Trotttargos
authored andcommitted
tools: add double-quotes to make-v8.sh
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: #41257 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ab5e94c commit e2df381
Copy full SHA for e2df381

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎tools/make-v8.sh‎

Copy file name to clipboardExpand all lines: tools/make-v8.sh
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
1717
fi
1818
# set paths manually for now to use locally installed gn
1919
export BUILD_TOOLS=/home/iojs/build-tools
20-
export LD_LIBRARY_PATH=$BUILD_TOOLS:$LD_LIBRARY_PATH
20+
export LD_LIBRARY_PATH="$BUILD_TOOLS:$LD_LIBRARY_PATH"
2121
# Avoid linking to ccache symbolic links as ccache decides which
2222
# binary to run based on the name of the link (we always name them gcc/g++).
2323
# shellcheck disable=SC2154
@@ -28,7 +28,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
2828
rm -f "$BUILD_TOOLS/gcc"
2929
ln -s "$CXX_PATH" "$BUILD_TOOLS/g++"
3030
ln -s "$CC_PATH" "$BUILD_TOOLS/gcc"
31-
export PATH=$BUILD_TOOLS:$PATH
31+
export PATH="$BUILD_TOOLS:$PATH"
3232

3333
g++ --version
3434
gcc --version

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.