Commit e22cc6c
test: fix race in test-net-server-pause-on-connect
A 50ms timeout results in a race condition. Instead, enforce expected
order through callbacks. This has the side effect of speeding up the
test in most situations.
Ref: #4476
PR-URL: #4637
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent d139704 commit e22cc6cCopy full SHA for e22cc6c
File tree
Expand file treeCollapse file tree
1 file changed
+26
-27
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+26
-27
lines changedOpen diff view settings
Collapse file
test/parallel/test-net-server-pause-on-connect.js
Copy file name to clipboard+26-27Lines changed: 26 additions & 27 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | | - |
3 | | - |
4 | | - |
5 | | - |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
6 | 6 | |
7 | | - |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
8 | 11 | |
9 | 12 | |
10 | | - |
| 13 | + |
11 | 14 | |
12 | 15 | |
13 | 16 | |
14 | 17 | |
15 | 18 | |
16 | 19 | |
17 | 20 | |
18 | | - |
19 | | - |
20 | | - |
21 | | - |
| 21 | + |
| 22 | + |
22 | 23 | |
23 | | - |
24 | | - |
25 | | - |
26 | | - |
| 24 | + |
27 | 25 | |
28 | | - |
29 | | - |
30 | | - |
31 | | - |
| 26 | + |
32 | 27 | |
33 | | - |
34 | | - |
35 | 28 | |
36 | 29 | |
37 | 30 | |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
38 | 35 | |
39 | | - |
| 36 | + |
40 | 37 | |
41 | | - |
42 | | - |
43 | | - |
| 38 | + |
44 | 39 | |
45 | | - |
46 | | - |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
47 | 47 | |
48 | 48 | |
49 | 49 | |
50 | 50 | |
51 | | - |
52 | 51 | |
0 commit comments