Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e1eb6a6

Browse filesBrowse files
bnoordhuistargos
authored andcommitted
test: scale keepalive timeouts for slow machines
The test was using fixed timeouts and that seems to be causing sporadic test failures on pi1-docker host (which is a very slow machine.) Fixes: #30828 PR-URL: #30834 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 2ae2727 commit e1eb6a6
Copy full SHA for e1eb6a6

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-https-server-keep-alive-timeout.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-https-server-keep-alive-timeout.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) {
3434
common.mustCall((req, res) => {
3535
res.end();
3636
}, 3));
37-
server.setTimeout(500, common.mustCall((socket) => {
37+
server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => {
3838
// End this test and call `run()` for the next test (if any).
3939
socket.destroy();
4040
server.close();
4141
cb();
4242
}));
43-
server.keepAliveTimeout = 50;
43+
server.keepAliveTimeout = common.platformTimeout(50);
4444
server.listen(0, common.mustCall(() => {
4545
const options = {
4646
port: server.address().port,
@@ -57,13 +57,13 @@ test(function serverKeepAliveTimeoutWithPipeline(cb) {
5757

5858
test(function serverNoEndKeepAliveTimeoutWithPipeline(cb) {
5959
const server = https.createServer(serverOptions, common.mustCall(3));
60-
server.setTimeout(500, common.mustCall((socket) => {
60+
server.setTimeout(common.platformTimeout(500), common.mustCall((socket) => {
6161
// End this test and call `run()` for the next test (if any).
6262
socket.destroy();
6363
server.close();
6464
cb();
6565
}));
66-
server.keepAliveTimeout = 50;
66+
server.keepAliveTimeout = common.platformTimeout(50);
6767
server.listen(0, common.mustCall(() => {
6868
const options = {
6969
port: server.address().port,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.