Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e16036c

Browse filesBrowse files
Matheus Marchinitargos
Matheus Marchini
authored and
targos
committed
test: create new directory v8-updates
`v8-updates` holds all tests related to V8 updates, for example, testing for postmortem metadata chages. PR-URL: #20783 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 03fbc9e commit e16036c
Copy full SHA for e16036c

File tree

Expand file treeCollapse file tree

6 files changed

+34
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+34
-4
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,6 +560,7 @@ test-with-async-hooks:
560560
.PHONY: test-v8-all
561561
.PHONY: test-v8-benchmarks
562562
.PHONY: test-v8-intl
563+
.PHONY: test-v8-updates
563564
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
564565
# Related CI job: node-test-commit-v8-linux
565566
test-v8: v8 ## Runs the V8 test suite on deps/v8.
@@ -580,7 +581,10 @@ test-v8-benchmarks: v8
580581
benchmarks \
581582
$(TAP_V8_BENCHMARKS)
582583

583-
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
584+
test-v8-updates:
585+
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) v8-updates
586+
587+
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks test-v8-updates
584588
# runs all v8 tests
585589
else
586590
test-v8 test-v8-intl test-v8-benchmarks test-v8-all:
Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ prefix parallel
55
# sample-test : PASS,FLAKY
66

77
[true] # This section applies to all platforms
8-
# Postmortem debugging data is prone to accidental removal during V8 updates.
9-
test-postmortem-metadata: PASS,FLAKY
108

119
[$system==win32]
1210
test-child-process-fork-net-socket: PASS,FLAKY
Collapse file

‎test/parallel/test-postmortem-metadata.js‎ ‎…t/v8-updates/test-postmortem-metadata.js‎test/parallel/test-postmortem-metadata.js renamed to test/v8-updates/test-postmortem-metadata.js test/parallel/test-postmortem-metadata.js renamed to test/v8-updates/test-postmortem-metadata.js

Copy file name to clipboard
File renamed without changes.
Collapse file

‎test/v8-updates/testcfg.py‎

Copy file name to clipboard
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import sys, os
2+
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
3+
import testpy
4+
5+
def GetConfiguration(context, root):
6+
return testpy.ParallelTestConfiguration(context, root, 'v8-updates')
Collapse file

‎test/v8-updates/v8-updates.status‎

Copy file name to clipboard
+21Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
prefix v8-updates
2+
3+
# To mark a test as flaky, list the test name in the appropriate section
4+
# below, without ".js", followed by ": PASS,FLAKY". Example:
5+
# sample-test : PASS,FLAKY
6+
7+
[true] # This section applies to all platforms
8+
9+
[$system==win32]
10+
11+
[$system==linux]
12+
13+
[$system==macos]
14+
15+
[$arch==arm || $arch==arm64]
16+
17+
[$system==solaris] # Also applies to SmartOS
18+
19+
[$system==freebsd]
20+
21+
[$system==aix]
Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1555,7 +1555,8 @@ def PrintCrashed(code):
15551555
'pummel',
15561556
'test-known-issues',
15571557
'tick-processor',
1558-
'timers'
1558+
'timers',
1559+
'v8-updates'
15591560
]
15601561

15611562

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.