Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e157e1c

Browse filesBrowse files
cjihrigMylesBorins
authored andcommitted
tools: simplify buffer-constructor rule
PR-URL: #17572 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent 01e7b44 commit e157e1c
Copy full SHA for e157e1c

File tree

Expand file treeCollapse file tree

1 file changed

+3
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-8
lines changed
Open diff view settings
Collapse file

‎tools/eslint-rules/buffer-constructor.js‎

Copy file name to clipboardExpand all lines: tools/eslint-rules/buffer-constructor.js
+3-8Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,11 @@
1010
const msg = 'Use of the Buffer() constructor has been deprecated. ' +
1111
'Please use either Buffer.alloc(), Buffer.allocUnsafe(), ' +
1212
'or Buffer.from()';
13-
14-
function test(context, node) {
15-
if (node.callee.name === 'Buffer') {
16-
context.report(node, msg);
17-
}
18-
}
13+
const astSelector = 'NewExpression[callee.name="Buffer"],' +
14+
'CallExpression[callee.name="Buffer"]';
1915

2016
module.exports = function(context) {
2117
return {
22-
'NewExpression': (node) => test(context, node),
23-
'CallExpression': (node) => test(context, node)
18+
[astSelector]: (node) => context.report(node, msg)
2419
};
2520
};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.