Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e14f864

Browse filesBrowse files
Trottaddaleax
authored andcommitted
lib,test: remove lib/internal/test/unicode.js
Remove lib/internal/test/unicode.js and associated test. When we added the file and test, only comments in lib had non-ASCII characters. Now, lib/internal/cli_table.js has non-ASCII characters. Tests that exercise the `console.table()` therefore fulfill the need to test non-ASCII characters in built-in modules. PR-URL: #25298 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9101591 commit e14f864
Copy full SHA for e14f864

File tree

Expand file treeCollapse file tree

4 files changed

+6
-21
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+6
-21
lines changed
Open diff view settings
Collapse file

‎lib/internal/cli_table.js‎

Copy file name to clipboardExpand all lines: lib/internal/cli_table.js
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ const { Buffer } = require('buffer');
44
const { removeColors } = require('internal/util');
55
const HasOwnProperty = Function.call.bind(Object.prototype.hasOwnProperty);
66

7+
// The use of Unicode characters below is the only non-comment use of non-ASCII
8+
// Unicode characters in Node.js built-in modules. If they are ever removed or
9+
// rewritten with \u escapes, then a test will need to be (re-)added to Node.js
10+
// core to verify that Unicode characters work in built-ins. Otherwise,
11+
// consumers using Unicode in _third_party_main.js will run into problems.
12+
// Refs: https://github.com/nodejs/node/issues/10673
713
const tableChars = {
814
/* eslint-disable node-core/non-ascii-character */
915
middleMiddle: '─',
Collapse file

‎lib/internal/test/unicode.js‎

Copy file name to clipboardExpand all lines: lib/internal/test/unicode.js
-8Lines changed: 0 additions & 8 deletions
This file was deleted.
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@
159159
'lib/internal/socket_list.js',
160160
'lib/internal/test/binding.js',
161161
'lib/internal/test/heap.js',
162-
'lib/internal/test/unicode.js',
163162
'lib/internal/timers.js',
164163
'lib/internal/tls.js',
165164
'lib/internal/trace_events_async_hooks.js',
Collapse file

‎test/parallel/test-internal-unicode.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-internal-unicode.js
-12Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.