Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e10eebf

Browse filesBrowse files
AndreasMadsenMyles Borins
authored andcommitted
async_wrap: make uid the first argument in init
All other hooks have uid as the first argument, this makes it concistent for all hooks. Ref: #7048 PR-URL: #4600 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 13d465b commit e10eebf
Copy full SHA for e10eebf

File tree

Expand file treeCollapse file tree

5 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

5 files changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎src/async-wrap-inl.h‎

Copy file name to clipboardExpand all lines: src/async-wrap-inl.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ inline AsyncWrap::AsyncWrap(Environment* env,
4040
v8::HandleScope scope(env->isolate());
4141

4242
v8::Local<v8::Value> argv[] = {
43-
v8::Int32::New(env->isolate(), provider),
4443
v8::Integer::New(env->isolate(), get_uid()),
44+
v8::Int32::New(env->isolate(), provider),
4545
Null(env->isolate())
4646
};
4747

Collapse file

‎test/parallel/test-async-wrap-check-providers.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-check-providers.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ if (common.isAix) {
2929
}
3030
}
3131

32-
function init(id) {
33-
keyList = keyList.filter((e) => e != pkeys[id]);
32+
function init(id, provider) {
33+
keyList = keyList.filter((e) => e != pkeys[provider]);
3434
}
3535

3636
function noop() { }
Collapse file

‎test/parallel/test-async-wrap-disabled-propagate-parent.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-disabled-propagate-parent.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const providers = Object.keys(async_wrap.Providers);
99
let cntr = 0;
1010
let client;
1111

12-
function init(type, id, parent) {
12+
function init(id, type, parent) {
1313
if (parent) {
1414
cntr++;
1515
// Cannot assert in init callback or will abort.
Collapse file

‎test/parallel/test-async-wrap-propagate-parent.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-propagate-parent.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const async_wrap = process.binding('async_wrap');
88
let cntr = 0;
99
let client;
1010

11-
function init(type, id, parent) {
11+
function init(id, type, parent) {
1212
if (parent) {
1313
cntr++;
1414
// Cannot assert in init callback or will abort.
Collapse file

‎test/parallel/test-async-wrap-uid.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-uid.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const storage = new Map();
99
async_wrap.setupHooks(init, pre, post, destroy);
1010
async_wrap.enable();
1111

12-
function init(provider, uid) {
12+
function init(uid) {
1313
storage.set(uid, {
1414
init: true,
1515
pre: false,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.