Commit e0cda56
tools: fix incorrect version history order
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).
minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.
Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.
Fixes: #45670
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 7438ff1 commit e0cda56Copy full SHA for e0cda56
File tree
Expand file treeCollapse file tree
2 files changed
+10
-9
lines changedOpen diff view settings
Filter options
- test/doctool
- tools/doc
Expand file treeCollapse file tree
2 files changed
+10
-9
lines changedOpen diff view settings
Collapse file
test/doctool/test-doctool-html.mjs
Copy file name to clipboardExpand all lines: test/doctool/test-doctool-html.mjs+3-2Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
79 | 79 | |
80 | 80 | |
81 | 81 | |
| 82 | + |
| 83 | + |
82 | 84 | |
83 | 85 | |
84 | | - |
85 | | - |
| 86 | + |
86 | 87 | |
87 | 88 | |
88 | 89 | |
|
Collapse file
+7-7Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
325 | 325 | |
326 | 326 | |
327 | 327 | |
328 | | - |
329 | | - |
| 328 | + |
| 329 | + |
330 | 330 | |
331 | 331 | |
332 | 332 | |
333 | | - |
| 333 | + |
334 | 334 | |
335 | | - |
| 335 | + |
336 | 336 | |
337 | 337 | |
338 | 338 | |
339 | | - |
340 | | - |
| 339 | + |
| 340 | + |
341 | 341 | |
342 | 342 | |
343 | 343 | |
344 | | - |
345 | 344 | |
346 | 345 | |
347 | 346 | |
348 | 347 | |
| 348 | + |
349 | 349 | |
350 | 350 | |
351 | 351 | |
|
0 commit comments