Commit e0bb118
committed
tls_wrap: inherit from the
`WrapperInfo` casts pointer in JS object's internal field to
`AsyncWrap`. This approach fails miserably for `TLSWrap` because it was
inhereted from the `StreamBase` first, creating different kind of
`vtable` for the whole class.
Reorder parent classes to put `AsyncWrap` first.
Fix: #4250
PR-URL: #4268
Reviewed-By: James M Snell <jasnell@gmail.com>AsyncWrap first1 parent d3c498b commit e0bb118Copy full SHA for e0bb118
File tree
Expand file treeCollapse file tree
2 files changed
+6
-6
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+6
-6
lines changedOpen diff view settings
Collapse file
+3-3Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
36 | 36 | |
37 | 37 | |
38 | 38 | |
39 | | - |
40 | | - |
41 | | - |
| 39 | + |
42 | 40 | |
43 | 41 | |
| 42 | + |
| 43 | + |
44 | 44 | |
45 | 45 | |
46 | 46 | |
|
Collapse file
+3-3Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
21 | 21 | |
22 | 22 | |
23 | 23 | |
24 | | - |
25 | | - |
26 | | - |
| 24 | + |
| 25 | + |
| 26 | + |
27 | 27 | |
28 | 28 | |
29 | 29 | |
|
0 commit comments