Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e0b4dab

Browse filesBrowse files
lotharthesaviorMylesBorins
authored andcommitted
test: fix assert.strictEqual() argument order
PR-URL: #23564 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 0fcbe2c commit e0b4dab
Copy full SHA for e0b4dab

File tree

Expand file treeCollapse file tree

1 file changed

+10
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+10
-10
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-tcp-wrap-connect.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tcp-wrap-connect.js
+10-10Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,19 @@ function makeConnection() {
1313
assert.strictEqual(err, 0);
1414

1515
req.oncomplete = function(status, client_, req_, readable, writable) {
16-
assert.strictEqual(0, status);
17-
assert.strictEqual(client, client_);
18-
assert.strictEqual(req, req_);
19-
assert.strictEqual(true, readable);
20-
assert.strictEqual(true, writable);
16+
assert.strictEqual(status, 0);
17+
assert.strictEqual(client_, client);
18+
assert.strictEqual(req_, req);
19+
assert.strictEqual(readable, true);
20+
assert.strictEqual(writable, true);
2121

2222
const shutdownReq = new ShutdownWrap();
2323
const err = client.shutdown(shutdownReq);
2424
assert.strictEqual(err, 0);
2525

2626
shutdownReq.oncomplete = function(status, client_, error) {
27-
assert.strictEqual(0, status);
28-
assert.strictEqual(client, client_);
27+
assert.strictEqual(status, 0);
28+
assert.strictEqual(client_, client);
2929
assert.strictEqual(error, undefined);
3030
shutdownCount++;
3131
client.close();
@@ -50,7 +50,7 @@ const server = require('net').Server(function(s) {
5050
server.listen(0, makeConnection);
5151

5252
process.on('exit', function() {
53-
assert.strictEqual(1, shutdownCount);
54-
assert.strictEqual(1, connectCount);
55-
assert.strictEqual(1, endCount);
53+
assert.strictEqual(shutdownCount, 1);
54+
assert.strictEqual(connectCount, 1);
55+
assert.strictEqual(endCount, 1);
5656
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.