Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e071651

Browse filesBrowse files
targosRafaelGSS
authored andcommitted
src: disable fast methods for buffer.write
It should resolve the regressions while we work on fixing them. Refs: #54521 PR-URL: #54565 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 825d933 commit e071651
Copy full SHA for e071651

File tree

Expand file treeCollapse file tree

1 file changed

+3
-15
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-15
lines changed
Open diff view settings
Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc
+3-15Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,21 +1554,9 @@ void Initialize(Local<Object> target,
15541554
SetMethod(context, target, "hexWrite", StringWrite<HEX>);
15551555
SetMethod(context, target, "ucs2Write", StringWrite<UCS2>);
15561556

1557-
SetFastMethod(context,
1558-
target,
1559-
"asciiWriteStatic",
1560-
SlowWriteString<ASCII>,
1561-
&fast_write_string);
1562-
SetFastMethod(context,
1563-
target,
1564-
"latin1WriteStatic",
1565-
SlowWriteString<LATIN1>,
1566-
&fast_write_string);
1567-
SetFastMethod(context,
1568-
target,
1569-
"utf8WriteStatic",
1570-
SlowWriteString<UTF8>,
1571-
&fast_write_string);
1557+
SetMethod(context, target, "asciiWriteStatic", SlowWriteString<ASCII>);
1558+
SetMethod(context, target, "latin1WriteStatic", SlowWriteString<LATIN1>);
1559+
SetMethod(context, target, "utf8WriteStatic", SlowWriteString<UTF8>);
15721560

15731561
SetMethod(context, target, "getZeroFillToggle", GetZeroFillToggle);
15741562
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.