Commit e049ce2
tls: reapply servername on happy eyeballs connect
When establishing a TLS connection to a server with `autoSelectFamily`
set to `true`, the `net.Socket` will call `[kWrapConnectedHandle]()` to
reinitialize the socket (in case if it got broken during previous
connect attempts). Unfortunately, prior to this patch this resulted in a
brand new `TLSWrap` instance being created for the socket. While most of
the configuration of `TLSWrap` is restored, the `servername` was sadly
dropped and not reinitalized.
With this patch `servername` will be reinitialized if there are
`tls.connect` options present on the `TLSSocket` instance, making it
possible to connect with "Happy Eyeballs" to TLS servers that require
the servername extension.
PR-URL: #48255
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>1 parent 033d0bb commit e049ce2Copy full SHA for e049ce2
File tree
Expand file treeCollapse file tree
2 files changed
+17
-4
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+17
-4
lines changedOpen diff view settings
Collapse file
+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
814 | 814 | |
815 | 815 | |
816 | 816 | |
| 817 | + |
| 818 | + |
| 819 | + |
| 820 | + |
| 821 | + |
| 822 | + |
| 823 | + |
| 824 | + |
817 | 825 | |
818 | 826 | |
819 | 827 | |
|
Collapse file
test/parallel/test-https-happy-eyeballs.js
Copy file name to clipboardExpand all lines: test/parallel/test-https-happy-eyeballs.js+9-4Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
80 | 80 | |
81 | 81 | |
82 | 82 | |
83 | | - |
| 83 | + |
| 84 | + |
84 | 85 | |
85 | 86 | |
86 | 87 | |
| ||
92 | 93 | |
93 | 94 | |
94 | 95 | |
95 | | - |
| 96 | + |
| 97 | + |
96 | 98 | |
97 | 99 | |
98 | 100 | |
| ||
118 | 120 | |
119 | 121 | |
120 | 122 | |
121 | | - |
| 123 | + |
| 124 | + |
122 | 125 | |
123 | 126 | |
124 | 127 | |
125 | 128 | |
126 | | - |
| 129 | + |
| 130 | + |
127 | 131 | |
128 | 132 | |
129 | 133 | |
| ||
139 | 143 | |
140 | 144 | |
141 | 145 | |
| 146 | + |
142 | 147 | |
143 | 148 | |
144 | 149 | |
|
0 commit comments