Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e039f2b

Browse filesBrowse files
aduh95marco-ippolito
authored andcommitted
tools: do not throw on missing create-release-proposal.sh
PR-URL: #56704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent ad39367 commit e039f2b
Copy full SHA for e039f2b

File tree

Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Collapse file

‎.github/workflows/create-release-proposal.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/create-release-proposal.yml
+2-5Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,10 @@ jobs:
7171
git config --local user.name "Node.js GitHub Bot"
7272
7373
- name: Start git node release prepare
74-
# `git update-index` tells git to ignore future changes to the `.sh` file,
75-
# `|| true` is there to ignore the error if such file doesn't exist yet.
7674
# The curl command is to make sure we run the version of the script corresponding to the current workflow.
7775
run: |
78-
git update-index --assume-unchanged tools/actions/create-release-proposal.sh || true
79-
curl -fsSLo tools/actions/create-release-proposal.sh https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release-proposal.sh
80-
./tools/actions/create-release-proposal.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}"
76+
curl -fsSL https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release-proposal.sh |\
77+
sh -s -- "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}"
8178
env:
8279
GH_TOKEN: ${{ github.token }}
8380
# We want the bot to push the push the release commit so CI runs on it.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.