Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit df05ddf

Browse filesBrowse files
RomainLanztargos
authored andcommitted
src: refactor deprecated v8::Function::Call call
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ab58439 commit df05ddf
Copy full SHA for df05ddf

File tree

Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+3-4Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,9 +1381,8 @@ void FatalException(Isolate* isolate,
13811381
fatal_try_catch.SetVerbose(false);
13821382

13831383
// This will return true if the JS layer handled it, false otherwise
1384-
Local<Value> caught =
1385-
fatal_exception_function.As<Function>()
1386-
->Call(process_object, 1, &error);
1384+
MaybeLocal<Value> caught = fatal_exception_function.As<Function>()->Call(
1385+
env->context(), process_object, 1, &error);
13871386

13881387
if (fatal_try_catch.HasTerminated())
13891388
return;
@@ -1392,7 +1391,7 @@ void FatalException(Isolate* isolate,
13921391
// The fatal exception function threw, so we must exit
13931392
ReportException(env, fatal_try_catch);
13941393
exit(7);
1395-
} else if (caught->IsFalse()) {
1394+
} else if (caught.ToLocalChecked()->IsFalse()) {
13961395
ReportException(env, error, message);
13971396

13981397
// fatal_exception_function call before may have set a new exit code ->

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.