Commit def8dea
contextify: ignore getters during initialization
The `context_` is not initialized until the `CreateV8Context` will
return. Make sure that it will be empty (by moving away initialization
from constructor) at start, and ignore getter callbacks until it will
have some value.
PR-URL: #2091
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent b30f393 commit def8deaCopy full SHA for def8dea
File tree
Expand file treeCollapse file tree
1 file changed
+23
-1
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+23
-1
lines changedOpen diff view settings
Collapse file
+23-1Lines changed: 23 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
65 | 65 | |
66 | 66 | |
67 | 67 | |
68 | | - |
69 | 68 | |
70 | 69 | |
| 70 | + |
| 71 | + |
71 | 72 | |
72 | 73 | |
73 | 74 | |
| ||
355 | 356 | |
356 | 357 | |
357 | 358 | |
| 359 | + |
| 360 | + |
| 361 | + |
| 362 | + |
358 | 363 | |
359 | 364 | |
360 | 365 | |
| ||
383 | 388 | |
384 | 389 | |
385 | 390 | |
| 391 | + |
| 392 | + |
| 393 | + |
| 394 | + |
386 | 395 | |
387 | 396 | |
388 | 397 | |
| ||
395 | 404 | |
396 | 405 | |
397 | 406 | |
| 407 | + |
| 408 | + |
| 409 | + |
| 410 | + |
398 | 411 | |
399 | 412 | |
400 | 413 | |
| ||
422 | 435 | |
423 | 436 | |
424 | 437 | |
| 438 | + |
| 439 | + |
| 440 | + |
| 441 | + |
| 442 | + |
425 | 443 | |
426 | 444 | |
427 | 445 | |
| ||
436 | 454 | |
437 | 455 | |
438 | 456 | |
| 457 | + |
| 458 | + |
| 459 | + |
| 460 | + |
439 | 461 | |
440 | 462 | |
441 | 463 | |
|
0 commit comments