Commit dee250f
http2: safer Http2Session destructor
It's hypothetically (and with certain V8 flags) possible for the session
to be garbage collected before all the streams are. In that case, trying
to remove the stream from the session will lead to a segfault due to
attempting to access no longer valid memory. Fix this by unsetting the
session on any streams still around when destroying.
PR-URL: #21194
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>1 parent 688bdfe commit dee250fCopy full SHA for dee250f
File tree
Expand file treeCollapse file tree
1 file changed
+8
-7
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+8
-7
lines changedOpen diff view settings
Collapse file
+8-7Lines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
499 | 499 | |
500 | 500 | |
501 | 501 | |
502 | | - |
503 | | - |
| 502 | + |
| 503 | + |
504 | 504 | |
505 | 505 | |
506 | 506 | |
| ||
1710 | 1710 | |
1711 | 1711 | |
1712 | 1712 | |
| 1713 | + |
| 1714 | + |
1713 | 1715 | |
1714 | | - |
1715 | | - |
1716 | | - |
1717 | | - |
| 1716 | + |
| 1717 | + |
1718 | 1718 | |
1719 | 1719 | |
1720 | 1720 | |
| ||
1789 | 1789 | |
1790 | 1790 | |
1791 | 1791 | |
1792 | | - |
| 1792 | + |
| 1793 | + |
1793 | 1794 | |
1794 | 1795 | |
1795 | 1796 | |
|
0 commit comments