Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit de5c009

Browse filesBrowse files
committed
test: adapt test-fs-write to V8 internal changes
PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 8c36168 commit de5c009
Copy full SHA for de5c009

File tree

Expand file treeCollapse file tree

1 file changed

+19
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+19
-6
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-fs-write.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-write.js
+19-6Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,23 @@ const fn4 = tmpdir.resolve('write4.txt');
3535
const expected = 'ümlaut.';
3636
const constants = fs.constants;
3737

38-
const { externalizeString, isOneByteString } = global;
38+
const {
39+
createExternalizableString,
40+
externalizeString,
41+
isOneByteString,
42+
} = global;
3943

4044
// Account for extra globals exposed by --expose_externalize_string.
41-
common.allowGlobals(externalizeString, isOneByteString, global.x);
45+
common.allowGlobals(
46+
createExternalizableString,
47+
externalizeString,
48+
isOneByteString,
49+
global.x,
50+
);
4251

4352
{
44-
const expected = 'ümlaut sechzig'; // Must be a unique string.
53+
// Must be a unique string.
54+
const expected = createExternalizableString('ümlaut sechzig');
4555
externalizeString(expected);
4656
assert.strictEqual(isOneByteString(expected), true);
4757
const fd = fs.openSync(fn, 'w');
@@ -51,7 +61,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
5161
}
5262

5363
{
54-
const expected = 'ümlaut neunzig'; // Must be a unique string.
64+
// Must be a unique string.
65+
const expected = createExternalizableString('ümlaut neunzig');
5566
externalizeString(expected);
5667
assert.strictEqual(isOneByteString(expected), true);
5768
const fd = fs.openSync(fn, 'w');
@@ -61,7 +72,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
6172
}
6273

6374
{
64-
const expected = 'Zhōngwén 1'; // Must be a unique string.
75+
// Must be a unique string.
76+
const expected = createExternalizableString('Zhōngwén 1');
6577
externalizeString(expected);
6678
assert.strictEqual(isOneByteString(expected), false);
6779
const fd = fs.openSync(fn, 'w');
@@ -71,7 +83,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
7183
}
7284

7385
{
74-
const expected = 'Zhōngwén 2'; // Must be a unique string.
86+
// Must be a unique string.
87+
const expected = createExternalizableString('Zhōngwén 2');
7588
externalizeString(expected);
7689
assert.strictEqual(isOneByteString(expected), false);
7790
const fd = fs.openSync(fn, 'w');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.