Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit de48407

Browse filesBrowse files
JonasBaaduh95
authored andcommitted
build: fix update-wpt workflow
PR-URL: #57468 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent f0c9f50 commit de48407
Copy full SHA for de48407

File tree

Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎.github/workflows/update-wpt.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/update-wpt.yml
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ jobs:
7070
- name: Open or update PR for the subsystem update
7171
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
7272
with:
73-
branch: actions/update-wpt-${{ matrix.subsystem }}
73+
# The create-or-update-pull-request-action matches the branch name by prefix,
74+
# which is why we need to add the -wpt suffix. If we dont do that, we risk matching wrong PRs,
75+
# like for example "url" mistakenly matching and updating the "urlpattern" PR
76+
# as seen in https://github.com/nodejs/node/pull/57368
77+
branch: actions/update-${{ matrix.subsystem }}-wpt
7478
author: Node.js GitHub Bot <github-bot@iojs.org>
7579
title: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'
7680
commit-message: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.