Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit de06115

Browse filesBrowse files
cjihrigtargos
authored andcommitted
fs: make fs.promises non-enumerable
This prevents the experimental feature warning from being emitted in cases where fs.promises is not actually used. PR-URL: #20632 Fixes: #20504 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
1 parent e06c587 commit de06115
Copy full SHA for de06115

File tree

Expand file treeCollapse file tree

2 files changed

+7
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+7
-2
lines changed
Open diff view settings
Collapse file

‎lib/fs.js‎

Copy file name to clipboardExpand all lines: lib/fs.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ let warn = true;
7777

7878
Object.defineProperty(fs, 'promises', {
7979
configurable: true,
80-
enumerable: true,
80+
enumerable: false,
8181
get() {
8282
if (warn) {
8383
warn = false;
Collapse file

‎test/parallel/test-fs-promises.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-promises.js
+6-1Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ const assert = require('assert');
55
const tmpdir = require('../common/tmpdir');
66
const fixtures = require('../common/fixtures');
77
const path = require('path');
8-
const fsPromises = require('fs').promises;
8+
const fs = require('fs');
9+
const fsPromises = fs.promises;
910
const {
1011
access,
1112
chmod,
@@ -38,6 +39,10 @@ const tmpDir = tmpdir.path;
3839

3940
common.crashOnUnhandledRejection();
4041

42+
// fs.promises should not be enumerable as long as it causes a warning to be
43+
// emitted.
44+
assert.strictEqual(Object.keys(fs).includes('promises'), false);
45+
4146
{
4247
access(__filename, 'r')
4348
.then(common.mustCall())

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.