Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ddb7df7

Browse filesBrowse files
santigimenoRafaelGSS
authored andcommitted
test: deflake test-http2-empty-frame-without-eof
It may happen that the data in `emptyframe.http2` reaches the client even before the client has started sending the request, causing an `ERR_HTTP2_STREAM_ERROR` instead. Fix this by making sure the frame is not sent until some data reaches the server. PR-URL: #45212 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent d9163f1 commit ddb7df7
Copy full SHA for ddb7df7

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http2-empty-frame-without-eof.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http2-empty-frame-without-eof.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ const { once } = require('events');
1010
async function main() {
1111
const blobWithEmptyFrame = readSync('emptyframe.http2');
1212
const server = net.createServer((socket) => {
13-
socket.end(blobWithEmptyFrame);
13+
socket.once('data', () => {
14+
socket.end(blobWithEmptyFrame);
15+
});
1416
}).listen(0);
1517
await once(server, 'listening');
1618

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.