Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit dcbf1d9

Browse filesBrowse files
danbevaddaleax
danbev
authored and
addaleax
committed
tools: add openssl-cli to macos-firewall.sh
Currently, there is a new popup asking to accept incoming connections for openssl-cli when running tests on macos. I believe the reason for this not being noticed before is that test-tls-securepair-client.js was moved recently from the pummel directory to sequential. This commit adds openssl-cli to the firewall script. PR-URL: #25385 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b545b4c commit dcbf1d9
Copy full SHA for dcbf1d9

File tree

Expand file treeCollapse file tree

1 file changed

+8
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-0
lines changed
Open diff view settings
Collapse file

‎tools/macos-firewall.sh‎

Copy file name to clipboardExpand all lines: tools/macos-firewall.sh
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ NODE_DEBUG="$OUTDIR/Debug/node"
1818
NODE_LINK="$ROOTDIR/node"
1919
CCTEST_RELEASE="$OUTDIR/Release/cctest"
2020
CCTEST_DEBUG="$OUTDIR/Debug/cctest"
21+
OPENSSL_CLI_RELEASE="$OUTDIR/Release/openssl-cli"
22+
OPENSSL_CLI_DEBUG="$OUTDIR/Debug/openssl-cli"
2123

2224
if [ -f $SFW ];
2325
then
@@ -31,18 +33,24 @@ then
3133
$SFW --remove "$NODE_LINK"
3234
$SFW --remove "$CCTEST_DEBUG"
3335
$SFW --remove "$CCTEST_RELEASE"
36+
$SFW --remove "$OPENSSL_CLI_DEBUG"
37+
$SFW --remove "$OPENSSL_CLI_RELEASE"
3438

3539
$SFW --add "$NODE_DEBUG"
3640
$SFW --add "$NODE_RELEASE"
3741
$SFW --add "$NODE_LINK"
3842
$SFW --add "$CCTEST_DEBUG"
3943
$SFW --add "$CCTEST_RELEASE"
44+
$SFW --add "$OPENSSL_CLI_DEBUG"
45+
$SFW --add "$OPENSSL_CLI_RELEASE"
4046

4147
$SFW --unblock "$NODE_DEBUG"
4248
$SFW --unblock "$NODE_RELEASE"
4349
$SFW --unblock "$NODE_LINK"
4450
$SFW --unblock "$CCTEST_DEBUG"
4551
$SFW --unblock "$CCTEST_RELEASE"
52+
$SFW --unblock "$OPENSSL_CLI_DEBUG"
53+
$SFW --unblock "$OPENSSL_CLI_RELEASE"
4654
else
4755
echo "SocketFirewall not found in location: $SFW"
4856
fi

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.