Commit dcaf723
src: minor refactor to node_errors.h
Add overloads of the error generation/throwing methods
that take an `Isolate*` argument, since the created objects
don’t depend on the `Environment*` in question.
Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the
same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way.
PR-URL: #23879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>1 parent 7bbc072 commit dcaf723Copy full SHA for dcaf723
File tree
Expand file treeCollapse file tree
2 files changed
+12
-14
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+12
-14
lines changedOpen diff view settings
Collapse file
+4-5Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
41 | 41 | |
42 | 42 | |
43 | 43 | |
44 | | - |
45 | | - |
| 44 | + |
46 | 45 | |
47 | 46 | |
48 | 47 | |
| ||
494 | 493 | |
495 | 494 | |
496 | 495 | |
497 | | - |
| 496 | + |
498 | 497 | |
499 | 498 | |
500 | 499 | |
| ||
685 | 684 | |
686 | 685 | |
687 | 686 | |
688 | | - |
| 687 | + |
689 | 688 | |
690 | 689 | |
691 | | - |
| 690 | + |
692 | 691 | |
693 | 692 | |
694 | 693 | |
|
Collapse file
+8-9Lines changed: 8 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
52 | 52 | |
53 | 53 | |
54 | 54 | |
| 55 | + |
| 56 | + |
| 57 | + |
55 | 58 | |
56 | | - |
| 59 | + |
57 | 60 | |
58 | 61 | |
59 | 62 | |
| ||
80 | 83 | |
81 | 84 | |
82 | 85 | |
| 86 | + |
| 87 | + |
| 88 | + |
83 | 89 | |
84 | | - |
| 90 | + |
85 | 91 | |
86 | 92 | |
87 | 93 | |
| ||
95 | 101 | |
96 | 102 | |
97 | 103 | |
98 | | - |
99 | | - |
100 | | - |
101 | | - |
102 | | - |
103 | | - |
104 | | - |
105 | 104 | |
106 | 105 | |
107 | 106 | |
|
0 commit comments