Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dca5ac1

Browse filesBrowse files
danbevtargos
authored andcommitted
deps: suppress zlib compiler warnings
Currently, there are a number of compilation warnings from zlib like the following one: ../deps/zlib/infback.c: In function ‘inflateBack’: ../deps/zlib/infback.c:479:25: warning: this statement may fall through [-Wimplicit-fallthrough=] 479 | state->mode = LEN; | ~~~~~~~~~~~~^~~~~ ../deps/zlib/infback.c:481:9: note: here 481 | case LEN: | ^~~~ In this case there is no break statement and the intention is to fall through: Tracev((stderr, "inflate: codes ok\n")); state->mode = LEN; case LEN: This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress these warnings. PR-URL: #40343 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 91c3bf6 commit dca5ac1
Copy full SHA for dca5ac1

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎deps/zlib/zlib.gyp‎

Copy file name to clipboardExpand all lines: deps/zlib/zlib.gyp
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
'conditions': [
5555
['OS!="win"', {
5656
'cflags!': [ '-ansi' ],
57+
'cflags': [ '-Wno-implicit-fallthrough' ],
5758
'defines': [ 'HAVE_HIDDEN' ],
5859
}],
5960
['OS=="mac" or OS=="ios" or OS=="freebsd" or OS=="android"', {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.