Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dc8c955

Browse filesBrowse files
dnluptargos
authored andcommitted
benchmark: replace var with let/const in cluster benchmark
PR-URL: #31042 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 9ed7d2e commit dc8c955
Copy full SHA for dc8c955

File tree

Expand file treeCollapse file tree

1 file changed

+8
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-9
lines changed
Open diff view settings
Collapse file

‎benchmark/cluster/echo.js‎

Copy file name to clipboardExpand all lines: benchmark/cluster/echo.js
+8-9Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ if (cluster.isMaster) {
1919
serialization
2020
}) {
2121
const expectedPerBroadcast = sendsPerBroadcast * workers;
22-
var readies = 0;
23-
var broadcasts = 0;
24-
var msgCount = 0;
25-
var data;
22+
let readies = 0;
23+
let broadcasts = 0;
24+
let msgCount = 0;
25+
let data;
2626

2727
cluster.settings.serialization = serialization;
2828

@@ -37,7 +37,7 @@ if (cluster.isMaster) {
3737
throw new Error('Unsupported payload type');
3838
}
3939

40-
for (var i = 0; i < workers; ++i)
40+
for (let i = 0; i < workers; ++i)
4141
cluster.fork().on('online', onOnline).on('message', onMessage);
4242

4343
function onOnline() {
@@ -48,16 +48,15 @@ if (cluster.isMaster) {
4848
}
4949

5050
function broadcast() {
51-
var id;
5251
if (broadcasts++ === n) {
5352
bench.end(n);
54-
for (id in cluster.workers)
53+
for (const id in cluster.workers)
5554
cluster.workers[id].disconnect();
5655
return;
5756
}
58-
for (id in cluster.workers) {
57+
for (const id in cluster.workers) {
5958
const worker = cluster.workers[id];
60-
for (var i = 0; i < sendsPerBroadcast; ++i)
59+
for (let i = 0; i < sendsPerBroadcast; ++i)
6160
worker.send(data);
6261
}
6362
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.