Commit dc38a45
debugger: fix event listener leak in the run command
It should remove both the error and the ready event listeners
attached when either of them fires, instead of removing only
the one whose corresponding event fires, otherwise the other
event listener will always get leaked.
PR-URL: #60464
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent dbf204c commit dc38a45Copy full SHA for dc38a45
File tree
Expand file treeCollapse file tree
3 files changed
+11
-8
lines changedOpen diff view settings
Filter options
- lib/internal/debugger
- test
- common
- parallel
Expand file treeCollapse file tree
3 files changed
+11
-8
lines changedOpen diff view settings
Collapse file
lib/internal/debugger/inspect_client.js
Copy file name to clipboardExpand all lines: lib/internal/debugger/inspect_client.js+5-8Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
13 | 13 | |
14 | 14 | |
15 | 15 | |
16 | | - |
| 16 | + |
17 | 17 | |
18 | 18 | |
19 | 19 | |
| ||
343 | 343 | |
344 | 344 | |
345 | 345 | |
346 | | - |
347 | | - |
348 | | - |
349 | | - |
350 | | - |
351 | | - |
352 | | - |
| 346 | + |
| 347 | + |
| 348 | + |
| 349 | + |
353 | 350 | |
354 | 351 | |
355 | 352 | |
|
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
141 | 141 | |
142 | 142 | |
143 | 143 | |
| 144 | + |
| 145 | + |
| 146 | + |
| 147 | + |
144 | 148 | |
145 | 149 | |
146 | 150 | |
|
Collapse file
test/parallel/test-debugger-restart-message.js
Copy file name to clipboardExpand all lines: test/parallel/test-debugger-restart-message.js+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
31 | 31 | |
32 | 32 | |
33 | 33 | |
| 34 | + |
| 35 | + |
34 | 36 | |
35 | 37 | |
36 | 38 | |
|
0 commit comments