Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dbb7727

Browse filesBrowse files
nfriedlyItalo A. Casas
authored andcommitted
test: validate 'expected' argument to mustCall()
instead of silently overwriting invalid values with the default PR-URL: #10692 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent e408f0a commit dbb7727
Copy full SHA for dbb7727

File tree

Expand file treeCollapse file tree

2 files changed

+12
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+12
-1
lines changed
Open diff view settings
Collapse file

‎test/common.js‎

Copy file name to clipboardExpand all lines: test/common.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,10 @@ function runCallChecks(exitCode) {
398398

399399

400400
exports.mustCall = function(fn, expected) {
401-
if (typeof expected !== 'number') expected = 1;
401+
if (expected === undefined)
402+
expected = 1;
403+
else if (typeof expected !== 'number')
404+
throw new TypeError(`Invalid expected value: ${expected}`);
402405

403406
const context = {
404407
expected: expected,
Collapse file

‎test/parallel/test-common.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-common.js
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,11 @@ var assert = require('assert');
55
common.globalCheck = false;
66
global.gc = 42; // Not a valid global unless --expose_gc is set.
77
assert.deepStrictEqual(common.leakedGlobals(), ['gc']);
8+
9+
assert.throws(function() {
10+
common.mustCall(function() {}, 'foo');
11+
}, /^TypeError: Invalid expected value: foo$/);
12+
13+
assert.throws(function() {
14+
common.mustCall(function() {}, /foo/);
15+
}, /^TypeError: Invalid expected value: \/foo\/$/);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.