Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dbae582

Browse filesBrowse files
danbevgibfahn
authored andcommitted
test: make CreateParams stack-allocated
PR-URL: #17366 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 77205b7 commit dbae582
Copy full SHA for dbae582

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/cctest/node_test_fixture.h‎

Copy file name to clipboardExpand all lines: test/cctest/node_test_fixture.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class NodeTestFixture : public ::testing::Test {
5959
static uv_loop_t* CurrentLoop() { return &current_loop; }
6060

6161
protected:
62-
v8::Isolate::CreateParams params_;
6362
v8::Isolate* isolate_;
6463

6564
~NodeTestFixture() {
@@ -71,6 +70,7 @@ class NodeTestFixture : public ::testing::Test {
7170
platform_ = new node::NodePlatform(8, &current_loop, nullptr);
7271
v8::V8::InitializePlatform(platform_);
7372
v8::V8::Initialize();
73+
v8::Isolate::CreateParams params_;
7474
params_.array_buffer_allocator = allocator_.get();
7575
isolate_ = v8::Isolate::New(params_);
7676
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.