Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit db79276

Browse filesBrowse files
addaleaxtargos
addaleax
authored and
targos
committed
tracing: remove shutdown-on-signal
This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc. What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output *need* to be able to handle abrupt ends meaningfully. Fixes: #14802 Fixes: #22528 PR-URL: #22734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent bc07612 commit db79276
Copy full SHA for db79276

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2052,7 +2052,6 @@ void SetupProcessObject(Environment* env,
20522052

20532053
void SignalExit(int signo) {
20542054
uv_tty_reset_mode();
2055-
v8_platform.StopTracingAgent();
20562055
#ifdef __FreeBSD__
20572056
// FreeBSD has a nasty bug, see RegisterSignalHandler for details
20582057
struct sigaction sa;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.