Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit db4b192

Browse filesBrowse files
addaleaxtargos
authored andcommitted
src: add not-weak DCHECK to PersistentToLocal::Strong
Refs: #38821 (comment) PR-URL: #38875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 7d35fa7 commit db4b192
Copy full SHA for db4b192

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -772,6 +772,7 @@ class PersistentToLocal {
772772
template <class TypeName>
773773
static inline v8::Local<TypeName> Strong(
774774
const v8::PersistentBase<TypeName>& persistent) {
775+
DCHECK(!persistent.IsWeak());
775776
return *reinterpret_cast<v8::Local<TypeName>*>(
776777
const_cast<v8::PersistentBase<TypeName>*>(&persistent));
777778
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.