Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dafed45

Browse filesBrowse files
committed
src: clean up experimental flag variables
- `fetch` is no longer disable by a CLI flag - `node:sqlite` requires SQLite, obviously Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #62759 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent a12dc44 commit dafed45
Copy full SHA for dafed45

4 files changed

+5-9Lines changed: 5 additions & 9 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/api/environment.cc‎

Copy file name to clipboardExpand all lines: src/api/environment.cc
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,13 +269,9 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
269269
isolate->SetModifyCodeGenerationFromStringsCallback(
270270
modify_code_generation_from_strings_callback);
271271

272-
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
273-
if (per_process::cli_options->get_per_isolate_options()
274-
->get_per_env_options()
275-
->experimental_fetch) {
276-
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
277-
}
272+
isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
278273

274+
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
279275
if (per_process::cli_options->get_per_isolate_options()
280276
->experimental_shadow_realm) {
281277
isolate->SetHostCreateShadowRealmContextCallback(
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
582582
"experimental node:sqlite module",
583583
&EnvironmentOptions::experimental_sqlite,
584584
kAllowedInEnvvar,
585-
true);
585+
HAVE_SQLITE);
586586
AddOption("--experimental-quic",
587587
#ifndef OPENSSL_NO_QUIC
588588
"experimental QUIC support",
Collapse file

‎src/node_options.h‎

Copy file name to clipboardExpand all lines: src/node_options.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,8 @@ class EnvironmentOptions : public Options {
124124
bool enable_source_maps = false;
125125
bool experimental_addon_modules = false;
126126
bool experimental_eventsource = false;
127-
bool experimental_fetch = true;
128127
bool experimental_websocket = true;
129-
bool experimental_sqlite = true;
128+
bool experimental_sqlite = HAVE_SQLITE;
130129
bool experimental_webstorage = false;
131130
#ifndef OPENSSL_NO_QUIC
132131
bool experimental_quic = false;
Collapse file

‎test/parallel/test-require-resolve.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-require-resolve.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
6262
builtinModules.forEach((mod) => {
6363
// TODO(@jasnell): Remove once node:quic is no longer flagged
6464
if (mod === 'node:quic') return;
65+
if (mod === 'node:sqlite' && !common.hasSQLite) return;
6566
assert.strictEqual(require.resolve.paths(mod), null);
6667
if (!mod.startsWith('node:')) {
6768
assert.strictEqual(require.resolve.paths(`node:${mod}`), null);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.