Commit dad3d74
test: fix compiler warning in doc/api/addons.md
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
args[0]->ToString(isolate));
^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
V8_DEPRECATED("Use maybe version",
^
This commit updates examples to use the non-deprecated versions.
PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent f63bf3f commit dad3d74Copy full SHA for dad3d74
File tree
Expand file treeCollapse file tree
1 file changed
+8
-3
lines changedOpen diff view settings
Filter options
- doc/api
Expand file treeCollapse file tree
1 file changed
+8
-3
lines changedOpen diff view settings
Collapse file
+8-3Lines changed: 8 additions & 3 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
587 | 587 | |
588 | 588 | |
589 | 589 | |
| 590 | + |
590 | 591 | |
591 | 592 | |
592 | 593 | |
| ||
596 | 597 | |
597 | 598 | |
598 | 599 | |
| 600 | + |
599 | 601 | |
600 | 602 | |
601 | | - |
| 603 | + |
| 604 | + |
602 | 605 | |
603 | 606 | |
604 | 607 | |
| ||
1078 | 1081 | |
1079 | 1082 | |
1080 | 1083 | |
| 1084 | + |
1081 | 1085 | |
1082 | 1086 | |
1083 | 1087 | |
| ||
1092 | 1096 | |
1093 | 1097 | |
1094 | 1098 | |
| 1099 | + |
1095 | 1100 | |
1096 | 1101 | |
1097 | | - |
| 1102 | + |
1098 | 1103 | |
1099 | | - |
| 1104 | + |
1100 | 1105 | |
1101 | 1106 | |
1102 | 1107 | |
|
0 commit comments