Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dad15cc

Browse filesBrowse files
addaleaxFishrock123
authored andcommitted
test: fix flaky test-vm-timeout
Likely fix the flaky parallel/test-vm-timeout. Increase the outer timeout in the test checking for nested timeouts with `vm` scripts so that its firing won’t interfere with the inner timeout. Fixes: #6727 PR-URL: #7373 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 044a0be commit dad15cc
Copy full SHA for dad15cc

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-vm-timeout.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-vm-timeout.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ assert.throws(function() {
2929
vm.runInNewContext('while(true) {}', context, { timeout: timeout });
3030
}
3131
};
32-
vm.runInNewContext('runInVM(10)', context, { timeout: 100 });
32+
vm.runInNewContext('runInVM(10)', context, { timeout: 10000 });
3333
throw new Error('Test 5 failed');
3434
}, /Script execution timed out./);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.